fix: add reflection configurations for com.google.rpc classes #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
|
For future improvement, if we don't worry too much about extra reflection configs, we can generate a common json for every common proto message in java-common-protos. Otherwise we may have to add these files manually for every handwritten library as we don't know what exactly common proto messages they are using. |
olavloite
approved these changes
Sep 12, 2023
Comment on lines
+1
to
+9
| [ { | ||
| "name": "com.google.rpc.LocalizedMessage", | ||
| "queryAllDeclaredConstructors": true, | ||
| "queryAllPublicConstructors": true, | ||
| "queryAllDeclaredMethods": true, | ||
| "allPublicMethods": true, | ||
| "allDeclaredClasses": true, | ||
| "allPublicClasses": true | ||
| }, |
There was a problem hiding this comment.
(Let's do this in a separate PR, and merge this now, so we can proceed with the releases)
There was a problem hiding this comment.
Applied change in follow-up PR #2621. Thanks.
olavloite
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
🤖 I have created a release *beep* *boop* --- ## [6.47.0](https://togithub.com/googleapis/java-spanner/compare/v6.46.0...v6.47.0) (2023-09-12) ### Features * Add devcontainers for enabling github codespaces usage. ([#2605](https://togithub.com/googleapis/java-spanner/issues/2605)) ([a7d60f1](https://togithub.com/googleapis/java-spanner/commit/a7d60f13781f87054a1631ca511492c5c8334751)) * Disable dynamic code loading properties by default ([#2606](https://togithub.com/googleapis/java-spanner/issues/2606)) ([d855ebb](https://togithub.com/googleapis/java-spanner/commit/d855ebbd2dec11cdd6cdbe326de81115632598cd)) ### Bug Fixes * Add reflection configurations for com.google.rpc classes ([#2617](https://togithub.com/googleapis/java-spanner/issues/2617)) ([c42460a](https://togithub.com/googleapis/java-spanner/commit/c42460ae7b6bb5874cc18c7aecff34186dcbff2a)) * Avoid unbalanced session pool creation ([#2442](https://togithub.com/googleapis/java-spanner/issues/2442)) ([db751ce](https://togithub.com/googleapis/java-spanner/commit/db751ceebc8b6981d00cd07ce4742196cc1dd50d)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.15.0 ([#2615](https://togithub.com/googleapis/java-spanner/issues/2615)) ([ac762fb](https://togithub.com/googleapis/java-spanner/commit/ac762fbf079db79eab5f2ebee971b850ac89eb11)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Agreed! This is something that we should we consider + discuss further. Additionally, we rely quite a bit tests to detect native image incompatibilities so if a handwritten library adds new code that explicitly uses |
surbhigarg92
pushed a commit
to surbhigarg92/java-spanner
that referenced
this pull request
Oct 5, 2023
…apis#2617) * fix: add native image configurations for com.google.rpc classes * relocate config to separate reflect-config.json files * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
surbhigarg92
pushed a commit
to surbhigarg92/java-spanner
that referenced
this pull request
Oct 5, 2023
🤖 I have created a release *beep* *boop* --- ## [6.47.0](https://togithub.com/googleapis/java-spanner/compare/v6.46.0...v6.47.0) (2023-09-12) ### Features * Add devcontainers for enabling github codespaces usage. ([googleapis#2605](https://togithub.com/googleapis/java-spanner/issues/2605)) ([a7d60f1](https://togithub.com/googleapis/java-spanner/commit/a7d60f13781f87054a1631ca511492c5c8334751)) * Disable dynamic code loading properties by default ([googleapis#2606](https://togithub.com/googleapis/java-spanner/issues/2606)) ([d855ebb](https://togithub.com/googleapis/java-spanner/commit/d855ebbd2dec11cdd6cdbe326de81115632598cd)) ### Bug Fixes * Add reflection configurations for com.google.rpc classes ([googleapis#2617](https://togithub.com/googleapis/java-spanner/issues/2617)) ([c42460a](https://togithub.com/googleapis/java-spanner/commit/c42460ae7b6bb5874cc18c7aecff34186dcbff2a)) * Avoid unbalanced session pool creation ([googleapis#2442](https://togithub.com/googleapis/java-spanner/issues/2442)) ([db751ce](https://togithub.com/googleapis/java-spanner/commit/db751ceebc8b6981d00cd07ce4742196cc1dd50d)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.15.0 ([googleapis#2615](https://togithub.com/googleapis/java-spanner/issues/2615)) ([ac762fb](https://togithub.com/googleapis/java-spanner/commit/ac762fbf079db79eab5f2ebee971b850ac89eb11)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For test failures in #2615
This PR adds native image metadata for the classes that are being invoked reflectively. The call to
ProtoUtils.keyForProtoinSpannerInterceptorProvidercallsGeneratedMessageV3#getMethodOrDiedown the line which then makes use of reflection to invoke methods in thegoogle.rpcclasses.https://github.com/protocolbuffers/protobuf/blob/2bea49218587ddb9cb2f76b75618ba70b1e11fa5/java/core/src/main/java/com/google/protobuf/GeneratedMessageV3.java#L1999-L2008
Stacktrace from IntelliJ debugger:
