Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove doc reference for THEN RETURN for batchUpdate #2639

Closed
wants to merge 1 commit into from
Closed

docs: remove doc reference for THEN RETURN for batchUpdate #2639

wants to merge 1 commit into from

Conversation

xinjiacs
Copy link

@xinjiacs xinjiacs commented Sep 25, 2023

Update the documentation of batch dml API to make it less confusing: calling out that you can use DML RETURNING in an API that doesn't support returning a result is weird.

…calling out that you can use DML RETURNING in an API that doesn't support returning a result is weird.
@xinjiacs xinjiacs requested a review from a team as a code owner September 25, 2023 20:20
@google-cla
Copy link

google-cla bot commented Sep 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 25, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Sep 25, 2023
@olavloite olavloite changed the title Update the documentation of batch dml API to make it less confusing: … docs: remove doc reference for THEN RETURN for batchUpdate Sep 26, 2023
@olavloite
Copy link
Collaborator

@xinjiacs I took the liberty of creating #2644 instead, so we can quickly get around the missing CLA issue. Hope you don't mind.

@olavloite olavloite closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants