feat(spanner): add support of using emulator using autogenerated admin clients #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: spanner
harshachinta
reviewed
Feb 6, 2024
| @@ -314,6 +318,20 @@ public static ApiClientHeaderProvider.Builder defaultApiClientHeaderProviderBuil | |||
|
|
|||
| /** Returns a new gRPC builder for this class. */ | |||
| public static Builder newBuilder() { | |||
| String hostAndPort = System.getenv(SPANNER_EMULATOR_HOST_ENV_VAR); | |||
There was a problem hiding this comment.
@olavloite has suggested not to add logic on autogenerated files since there is a chance of this file getting overwritten during the next autogenerated PRs.
In NodeJS, we are writing a function similar to Python which can return a new autogenerated admin client with the emulator host set.
There was a problem hiding this comment.
yes, there's similar requirement in other client libs.
Bigtable https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminSettings.java#L56 has logic to use emulator in their classes.
|
Closing this in favor of - #2878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar handwritten
hook in Go https://github.com/googleapis/google-cloud-go/blob/main/spanner/admin/database/apiv1/init.go