Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FileSystemProvider::checkAccess fails on '/' with StorageException #1065

Merged
merged 1 commit into from Dec 7, 2022

Conversation

nielsbasjes
Copy link
Contributor

@nielsbasjes nielsbasjes commented Dec 3, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #1062 ☕️

BEGIN_COMMIT_OVERRIDE
fix: FileSystemProvider::checkAccess fails on '/' with StorageException
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage-nio API. labels Dec 3, 2022
@nielsbasjes
Copy link
Contributor Author

First check if the test I added actually fails the build.

@nielsbasjes
Copy link
Contributor Author

@BenWhitehead I was hoping to verify my new test to prove the problem I'm trying to fix (TDD) yet the integration test is taking very long to show the status. Any idea how I can view what is happening?

@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2022
@BenWhitehead
Copy link
Collaborator

I need to manually trigger the integration tests to run. I've done that and you should be able to see results in ~15min or so

@BenWhitehead
Copy link
Collaborator

Alternatively, you should be able to run the integration tests in your own environment by running mvn -Penable-integration-tests verify

@nielsbasjes
Copy link
Contributor Author

Alternatively, you should be able to run the integration tests in your own environment by running mvn -Penable-integration-tests verify

Yes, I tried that but given the restrictions I have with my work Google account I couldn't get it to run from my laptop. This has proven my test indeed triggers the error I'm trying to solve. Thanks.

@nielsbasjes nielsbasjes marked this pull request as ready for review December 5, 2022 22:24
@nielsbasjes nielsbasjes requested a review from a team as a code owner December 5, 2022 22:24
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 5, 2022
@BenWhitehead BenWhitehead added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@BenWhitehead BenWhitehead added the automerge Merge the pull request once unit tests and other checks pass. label Dec 7, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit d287cf5 into googleapis:main Dec 7, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 7, 2022
@BenWhitehead BenWhitehead changed the title FileSystemProvider::checkAccess fails on '/' with StorageException fix: FileSystemProvider::checkAccess fails on '/' with StorageException Dec 7, 2022
@BenWhitehead BenWhitehead added the release-please:force-run To run release-please label Dec 7, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Dec 7, 2022
@BenWhitehead BenWhitehead added the release-please:force-run To run release-please label Dec 7, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage-nio API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java Storage NIO: FileSystemProvider::checkAccess fails on '/' with StorageException
3 participants