fix: remove PCU internals which should be hidden (#2263)

googleapis · Oct 17, 2023 · eff00fb · eff00fb
1 parent c5274ce
commit eff00fb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/google-cloud-storage/clirr-ignored-differences.xml b/google-cloud-storage/clirr-ignored-differences.xml
@@ -15,4 +15,20 @@
     <method>* writeAndClose(*)</method>
   </difference>
 
+  <!-- @BetaApi members -->
+  <difference>
+    <differenceType>7009</differenceType>
+    <className>com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartCleanupStrategy</className>
+    <method>boolean isDeleteAllOnError()</method>
+  </difference>
+  <difference>
+    <differenceType>7009</differenceType>
+    <className>com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartCleanupStrategy</className>
+    <method>boolean isDeletePartsOnSuccess()</method>
+  </difference>
+  <difference>
+    <differenceType>7009</differenceType>
+    <className>com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartNamingStrategy</className>
+    <method>java.lang.String fmtFields(*)</method>
+  </difference>
 </differences>
diff --git a/...src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java b/...src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
@@ -467,7 +467,7 @@ String fmtName(String ultimateObjectName, PartRange partRange) {
       return fmtFields(randomKey, nameDigest, partRange.encode());
     }
 
-    protected abstract String fmtFields(String randomKey, String nameDigest, String partRange);
+    abstract String fmtFields(String randomKey, String nameDigest, String partRange);
 
     /**
      * Default strategy in which no stable prefix is defined.
@@ -588,11 +588,11 @@ private PartCleanupStrategy(boolean deletePartsOnSuccess, boolean deleteAllOnErr
       this.deleteAllOnError = deleteAllOnError;
     }
 
-    public boolean isDeletePartsOnSuccess() {
+    boolean isDeletePartsOnSuccess() {
       return deletePartsOnSuccess;
     }
 
-    public boolean isDeleteAllOnError() {
+    boolean isDeleteAllOnError() {
       return deleteAllOnError;
     }