test: migrate tests which previously had hard coded object names to use new Generator#randomObjectName() #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
BenWhitehead
force-pushed
the
test/gen-obj-names-pt2
branch
from
2e79791
to
4fea88f
Compare
…nloadBlobWithoutAuth
…teChannelConnectionPoolTest Log a warning message if a test has defined a junit timeout. Defining a junit timeout runs the test on another thread which we don't control, and don't control the migration of.
…chTest Rewrite testBatchRequestManyOperations to be more straightforward. Rather than generating 100 different operations which are then bucketed, define the 5 high level operations we're verifying.
BenWhitehead
force-pushed
the
test/gen-obj-names-pt2
branch
from
4fea88f
to
faebdf0
Compare
frankyn
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1826
Migrate tests which previously had hard coded object names to use new
Generator#randomObjectName().Serval test which were previously using
@Rule Timeoutor@Test(timeout = N)have had their timeouts removed. The Timeout implementation in JUnit 4 is not thread safe, and can result in running test tracking issues.The majority of these tests have had their timeouts made completely obsolete in #1824 and their change here will be short lived.
Each commit in this PR is migrating a single IT class.