Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update GrpcStorageOptions to set allowNonDefaultServiceAccount = true #1977

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix: update GrpcStorageOptions to set allowNonDefaultServiceAccount = true #1977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ private Tuple<StorageSettings, Opts<UserProject>> resolveSettingsAndOpts() throw
InstantiatingGrpcChannelProvider.Builder channelProviderBuilder =
InstantiatingGrpcChannelProvider.newBuilder()
.setEndpoint(endpoint)
.setAllowNonDefaultServiceAccount(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we think this should always be true? Should this be configurable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling, is this flag is there to support some old client which didn't have this capability. However, in the case of storage I think we always want to allow any kind of credential without requiring the customer to also know they need to flip this flag. I mean hell, I didn't even know this flag existed until dataproc tried to use the library and was surprised they weren't getting direct path and tracked it down to the credentials.

.setAttemptDirectPath(attemptDirectPath);

if (scheme.equals("http")) {
Expand Down