Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove PCU internals which should be hidden #2263

Merged
merged 1 commit into from Oct 17, 2023
+19 −3
Merged

fix: remove PCU internals which should be hidden #2263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions google-cloud-storage/clirr-ignored-differences.xml
View file
Open in desktop
Expand Up @@ -15,4 +15,20 @@
<method>* writeAndClose(*)</method>
</difference>

<!-- @BetaApi members -->
<difference>
<differenceType>7009</differenceType>
<className>com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartCleanupStrategy</className>
<method>boolean isDeleteAllOnError()</method>
</difference>
<difference>
<differenceType>7009</differenceType>
<className>com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartCleanupStrategy</className>
<method>boolean isDeletePartsOnSuccess()</method>
</difference>
<difference>
<differenceType>7009</differenceType>
<className>com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig$PartNamingStrategy</className>
<method>java.lang.String fmtFields(*)</method>
</difference>
</differences>
6 changes: 3 additions & 3 deletions ...src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
View file
Open in desktop
Expand Up @@ -467,7 +467,7 @@ String fmtName(String ultimateObjectName, PartRange partRange) {
return fmtFields(randomKey, nameDigest, partRange.encode());
}

protected abstract String fmtFields(String randomKey, String nameDigest, String partRange);
abstract String fmtFields(String randomKey, String nameDigest, String partRange);

/**
* Default strategy in which no stable prefix is defined.
Expand Down Expand Up @@ -588,11 +588,11 @@ private PartCleanupStrategy(boolean deletePartsOnSuccess, boolean deleteAllOnErr
this.deleteAllOnError = deleteAllOnError;
}

public boolean isDeletePartsOnSuccess() {
boolean isDeletePartsOnSuccess() {
return deletePartsOnSuccess;
}

public boolean isDeleteAllOnError() {
boolean isDeleteAllOnError() {
return deleteAllOnError;
}

Expand Down