test: convert a portion of tests from easymock to mockito #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
============================================
+ Coverage 64.32% 64.43% +0.11%
Complexity 630 630
============================================
Files 32 32
Lines 5317 5317
Branches 519 519
============================================
+ Hits 3420 3426 +6
+ Misses 1735 1729 -6
Partials 162 162
Continue to review full report at Codecov.
|
elharo
reviewed
Nov 25, 2020
google-cloud-storage/src/test/java/com/google/cloud/storage/StorageImplMockitoTest.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/StorageImplMockitoTest.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/StorageImplMockitoTest.java
Outdated
Show resolved
Hide resolved
| CopyWriter writer = storage.copy(request); | ||
| assertEquals(42L, writer.getBlobSize()); | ||
| assertEquals(21L, writer.getTotalBytesCopied()); | ||
| assertTrue(!writer.isDone()); |
dmitry-fa
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #270
For the convenience of reviewers this PR comprises two commits, the second commit allows to see the converted tests as if there were changed, not added.