Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove the blob error workaround #1072

Merged
merged 2 commits into from
Feb 24, 2023
Merged

chore: remove the blob error workaround #1072

merged 2 commits into from
Feb 24, 2023

Conversation

danieljbruce
Copy link
Contributor

@danieljbruce danieljbruce commented Feb 24, 2023 •
edited

An error with code 3 was thrown when the test code was run before the workaround was added and before the proto changes were made. Now that the proto changes have been made, the workaround is no longer required so it is removed in this commit.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #755 馃

@danieljbruce
remove the blob error workaround
83e985d 
An error with code 3 was thrown when the test code was run before the workaround was added and before the proto changes were made. Now that the proto changes have been made, the workaround is no longer required so it is removed in this commit.
@danieljbruce danieljbruce requested review from a team as code owners February 24, 2023 16:28
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 24, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Feb 24, 2023 •
edited

馃 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/nodejs-datastore API. label Feb 24, 2023
@danieljbruce
return encode test to original
d299cd0 
Change a test so that it matches what it originally was back in 2020.
@danieljbruce danieljbruce mentioned this pull request Feb 24, 2023
Closed
@danieljbruce danieljbruce added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@danieljbruce danieljbruce merged commit 6ce2e5b into googleapis:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saving an empty Buffer throws an error.
2 participants
@danieljbruce @ruyadorno