feat: typings for gapic files #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
callmehiphop
added
the
do not merge
callmehiphop
added
do not merge
callmehiphop
removed
the
do not merge
| * limitations under the License. | ||
| */ | ||
|
|
||
| export {DatastoreClient} from './datastore_client'; |
There was a problem hiding this comment.
🙋 it looks like this overlaps with the proto method of generating these in #305?
There was a problem hiding this comment.
Yeah, I didn't even notice that PR existed until I submitted this one, lol. I think there's still value in this PR since #305 does not supply types to the gapics, although it would probably be beneficial to wait for it to land and re-use the interfaces instead of having similar ones/duplicates.
JustinBeckwith
approved these changes
Jan 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.