Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix CI failing on new Mocha unhandledRejection listener #528

Merged
merged 1 commit into from
Nov 3, 2020
Merged

test: fix CI failing on new Mocha unhandledRejection listener #528

merged 1 commit into from
Nov 3, 2020

Conversation

0xSage
Copy link
Contributor

@0xSage 0xSage commented Nov 3, 2020

Fixes #526 🦕

@0xSage 0xSage requested a review from a team as a code owner November 3, 2020 01:23
@0xSage 0xSage self-assigned this Nov 3, 2020
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Nov 3, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2020
@0xSage 0xSage added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: process A process-related concern. May include testing, release, or the like. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 3, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2020
@0xSage 0xSage requested a review from a team November 3, 2020 01:52
@codecov
Copy link

codecov bot commented Nov 3, 2020 •
edited

Codecov Report

Merging #528 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   78.59%   78.65%   +0.06%     
==========================================
  Files          23       23              
  Lines        3158     3158              
  Branches      217      206      -11     
==========================================
+ Hits         2482     2484       +2     
+ Misses        674      671       -3     
- Partials        2        3       +1
Impacted Files Coverage Δ
src/configuration.ts 96.23% <0.00%> (ø)
utils/fuzzer.ts 85.85% <0.00%> (+0.33%) ⬆️
src/google-apis/auth-client.ts 71.42% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad8365...61973b7. Read the comment docs.

@0xSage
Copy link
Contributor Author

0xSage commented Nov 3, 2020

@googleapis/yoshi-nodejs what are test(14) and test(15)`? I noticed this test was stuck for all previous merged PRs as well

@simonz130 simonz130 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 3, 2020
@bcoe bcoe merged commit 8d73781 into master Nov 3, 2020
laljikanjareeya pushed a commit to laljikanjareeya/nodejs-error-reporting that referenced this pull request Nov 11, 2020
@yoshi-automation
build: do not fail builds on codecov errors (googleapis#528) (googlea…
ba1e882 
…pis#479)

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/13e8b547-7af0-436b-b85e-2c1942f8f36a/targets

Source-Link: googleapis/synthtool@be74d3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@simonz130 simonz130 simonz130 approved these changes

Assignees

@0xSage 0xSage

Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. cla: yes This human has signed the Contributor License Agreement. kokoro:run Add this label to force Kokoro to re-run the tests. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test in CI: caused by Mocha's new unhandledRejection listener
3 participants
@0xSage @bcoe @simonz130