Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix Mocha patch with undefined timeout error #547

Merged
merged 1 commit into from Mar 8, 2021

Conversation

0xSage
Copy link
Contributor

@0xSage 0xSage commented Mar 8, 2021

Concurrent with Alex's upstream Mocha fix
Making the syntax conformant with the rest of the Node tests, which call this.timeout

@0xSage 0xSage self-assigned this Mar 8, 2021
@0xSage 0xSage requested review from a team as code owners March 8, 2021 21:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2021
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #547 (2dec164) into master (d39d723) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #547   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files          23       23           
  Lines        3160     3160           
  Branches      200      200           
=======================================
  Hits         2486     2486           
  Misses        671      671           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39d723...ccf7a44. Read the comment docs.

@simonz130 simonz130 merged commit 419a5e1 into master Mar 8, 2021
@simonz130 simonz130 deleted the fixMochaTimeout branch March 8, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants