fix: use BigInt when calculating nanos in Timestamp.fromMillis() #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: firestore
google-cla
bot
added
the
cla: yes
added 2 commits
April 8, 2021 10:50
|
Build is broken b/c of sinon update, but will merge once it's fixed. |
schmidt-sebastian
approved these changes
Apr 8, 2021
thebrianchen
added
the
kokoro:force-run
thebrianchen
added
the
kokoro:run
yoshi-kokoro
removed
kokoro:run
Codecov Report
@@ Coverage Diff @@
## master #1468 +/- ##
==========================================
+ Coverage 98.20% 98.21% +0.01%
==========================================
Files 32 32
Lines 19569 19567 -2
Branches 1285 1373 +88
==========================================
Hits 19217 19217
+ Misses 348 346 -2
Partials 4 4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After porting the original change to the web SDK, I noticed that the nanos calculation is subject to floating point precision loss. I used Math.floor() on the Web SDK, but using BigInt is more accurate, so I prefer to use it where we can.