Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additionalProperties to SchemaItem #34

Merged
merged 1 commit into from Oct 30, 2018
Merged

Add additionalProperties to SchemaItem #34

merged 1 commit into from Oct 30, 2018

Conversation

ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Oct 30, 2018

Add missing additionalProperties to SchemaItem as a precursor to fix 1383

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
@JustinBeckwith JustinBeckwith merged commit 103bfd7 into googleapis:master Oct 30, 2018
@ajaaym ajaaym mentioned this pull request Oct 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poor Typings for Schema$InstanceAggregatedList
3 participants
@ajaaym @JustinBeckwith @googlebot