Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it ready for use in browser #69

Merged
merged 15 commits into from Jan 17, 2019
Merged

feat: make it ready for use in browser #69

merged 15 commits into from Jan 17, 2019

Conversation

alexander-fenster
Copy link
Member

@alexander-fenster alexander-fenster commented Jan 7, 2019

Making this library ready for browser usage. These changes are going to be released as v0.6.0 in a separate PR.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2019
@alexander-fenster alexander-fenster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 7, 2019
@alexander-fenster alexander-fenster changed the title DO NOT MERGE: feat: make it ready for use in browser feat: make it ready for use in browser Jan 16, 2019
@alexander-fenster alexander-fenster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 16, 2019
@JustinBeckwith
Copy link
Contributor

👋 @alexander-fenster this is updated with the latest gaxios and google-auth-library :)

@alexander-fenster
Copy link
Member Author

@JustinBeckwith I added 'some kind of test' as you asked.

@kinwa91 Can you please enable browser testing for this repo, just like you did for auth library? I think I put all the Kokoro configs in place, but would be great if you double check :)

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@JustinBeckwith JustinBeckwith merged commit dbb645a into master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants