Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export AuthPlus #70

Merged
merged 2 commits into from Jan 10, 2019
Merged

feat: export AuthPlus #70

merged 2 commits into from Jan 10, 2019

Conversation

alexander-fenster
Copy link
Member

@alexander-fenster alexander-fenster commented Jan 10, 2019 •
edited

Export AuthPlus (copied from to make it possible to use it from google-api-nodejs-client micropackages, and release v0.5.0.

Copied from here:

https://github.com/googleapis/google-api-nodejs-client/blob/7e07d11f2c0573f70538adebf79d46f4e63515cd/src/googleapis.ts#L14-L26

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2019
JustinBeckwith
JustinBeckwith approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please make sure to follow up by removing de-duplicating the code in the googleapis repo :)

@alexander-fenster alexander-fenster merged commit 4b4cd4a into master Jan 10, 2019
@alexander-fenster alexander-fenster deleted the export-authplus-release-0.5.0 branch January 10, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-fenster @JustinBeckwith @googlebot