Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: patch Mocha timeout issue upstream #516

Merged
merged 1 commit into from Mar 8, 2021
Merged

test: patch Mocha timeout issue upstream #516

merged 1 commit into from Mar 8, 2021

Conversation

0xSage
Copy link
Contributor

@0xSage 0xSage commented Mar 8, 2021

Concurrent with Alex's upstream Mocha fix here
Making the syntax conformant with the rest of the Node tests, which call this.timeout

@0xSage 0xSage requested review from a team as code owners March 8, 2021 22:13
@0xSage 0xSage self-assigned this Mar 8, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-bunyan API. label Mar 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #516 (26c7b99) into master (59e823b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #516   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files           4        4           
  Lines         497      497           
  Branches       34       37    +3     
=======================================
  Hits          465      465           
  Misses         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e823b...26c7b99. Read the comment docs.

@simonz130 simonz130 merged commit 2771d92 into master Mar 8, 2021
@simonz130 simonz130 deleted the fixMocha branch March 8, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/nodejs-logging-bunyan API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants