Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency cpy-cli to v4 #647

Merged
merged 5 commits into from
Sep 13, 2022
Merged

chore(deps): update dependency cpy-cli to v4 #647

merged 5 commits into from
Sep 13, 2022

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Aug 10, 2022

No description provided.

@sofisl sofisl requested review from a team as code owners August 10, 2022 22:30
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 10, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-bunyan API. label Aug 10, 2022
@losalex losalex changed the title try fixing cpy-cli fix: try fixing cpy-cli Aug 11, 2022
losalex
losalex reviewed Aug 11, 2022
View reviewed changes
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test still fails with "error TS2307: Cannot find module './types/core' or its corresponding type declarations.". I wonder if we really need to update cp-cli - it seems that this change requires extra dependency, correct?

losalex
losalex reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still fails...

@sofisl
Copy link
Contributor Author

sofisl commented Aug 18, 2022

@losalex, this is an attempt at updating this dependency: #598

I'm not sure how to fix it, it seems like this ugprade is buggy: sindresorhus/cpy-cli#35 (there are more as well). I haven't had the chance to come back and look at this yet, if you do have cycles to upgrade it correctly I'd greatly appreciate it!

@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Sep 10, 2022
@sofisl sofisl changed the title fix: try fixing cpy-cli chore(deps): update dependency cpy-cli to v4 Sep 13, 2022
losalex
losalex approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this - much appreciated!

@losalex losalex merged commit 266b392 into main Sep 13, 2022
@losalex losalex deleted the fixCpyCli branch September 13, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losalex losalex losalex approved these changes

Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/nodejs-logging-bunyan API. size: xs Pull request size is extra small. stale: old Pull request is old and needs attention.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sofisl @losalex