Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retreive log entries from logging bucket #1482

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Colt45s
Copy link

@Colt45s Colt45s commented Jan 18, 2024

I also attempted to retrieve log entries from the logging bucket similar #1411, but couldn鈥檛.

According to this document, specify views in resourceNames for entries from logging buckets, as an alternative to parent resources.


Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1411 馃

@Colt45s Colt45s requested review from a team as code owners January 18, 2024 00:38
Copy link

google-cla bot commented Jan 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: logging Issues related to the googleapis/nodejs-logging API. labels Jan 18, 2024
@Colt45s

This comment has been minimized.

@cindy-peng cindy-peng requested review from cindy-peng and removed request for daniel-sanche and cindy-peng January 23, 2024 19:25
@Colt45s Colt45s force-pushed the fix/retreive-log-entries-from-logging-bucket branch from 638905d to f3b8cde Compare January 24, 2024 04:59
@Colt45s
Copy link
Author

Colt45s commented Feb 6, 2024

Could you please review my pull request, @cindy-peng ?

@vjerci
Copy link

vjerci commented Feb 12, 2024

+1 on needing this.

@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Feb 17, 2024
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/nodejs-logging API. size: s Pull request size is small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to retreive log entries
3 participants