Skip to content

Commit

Permalink
build!: update library to use Node 12 (#325)
Browse files Browse the repository at this point in the history
* feat!: Update library to use Node 12

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
alexander-fenster and gcf-owl-bot[bot] committed May 17, 2022
1 parent 650a44e commit 02887ae
Show file tree
Hide file tree
Showing 21 changed files with 8 additions and 177 deletions.
2 changes: 1 addition & 1 deletion .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ branchProtectionRules:
- "ci/kokoro: System test"
- docs
- lint
- test (10)
- test (12)
- test (14)
- test (16)
- cla/google
- windows
- OwlBot Post Processor
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10, 12, 14]
node: [12, 14, 16]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
34 changes: 0 additions & 34 deletions .kokoro/continuous/node10/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node10/docs.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node10/lint.cfg

This file was deleted.

7 changes: 0 additions & 7 deletions .kokoro/continuous/node10/samples-test.cfg

This file was deleted.

7 changes: 0 additions & 7 deletions .kokoro/continuous/node10/system-test.cfg

This file was deleted.

9 changes: 0 additions & 9 deletions .kokoro/continuous/node10/test.cfg

This file was deleted.

24 changes: 0 additions & 24 deletions .kokoro/continuous/node8/common.cfg

This file was deleted.

Empty file removed .kokoro/continuous/node8/test.cfg
Empty file.
34 changes: 0 additions & 34 deletions .kokoro/presubmit/node10/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/presubmit/node10/docs.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/presubmit/node10/lint.cfg

This file was deleted.

7 changes: 0 additions & 7 deletions .kokoro/presubmit/node10/samples-test.cfg

This file was deleted.

7 changes: 0 additions & 7 deletions .kokoro/presubmit/node10/system-test.cfg

This file was deleted.

Empty file removed .kokoro/presubmit/node10/test.cfg
Empty file.
24 changes: 0 additions & 24 deletions .kokoro/presubmit/node8/common.cfg

This file was deleted.

Empty file removed .kokoro/presubmit/node8/test.cfg
Empty file.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,17 @@
"codecov": "^3.0.4",
"gts": "^3.0.0",
"linkinator": "^2.0.0",
"mocha": "^8.0.0",
"mocha": "^9.2.2",
"proxyquire": "^2.0.1",
"sinon": "^14.0.0",
"typescript": "^3.8.3",
"typescript": "^4.6.4",
"uuid": "^8.0.0"
},
"dependencies": {
"arrify": "^2.0.0",
"extend": "^3.0.2"
},
"engines": {
"node": ">=10"
"node": ">=12.0.0"
}
}
4 changes: 2 additions & 2 deletions samples/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"license": "Apache-2.0",
"author": "Google LLC",
"engines": {
"node": ">=10"
"node": ">=12.0.0"
},
"repository": "googleapis/nodejs-paginator",
"private": true,
Expand All @@ -16,4 +16,4 @@
"devDependencies": {
"mocha": "^8.0.0"
}
}
}
2 changes: 1 addition & 1 deletion src/resource-stream.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class ResourceStream<T> extends Transform implements ResourceEvents<T> {
}
);
} catch (e) {
this.destroy(e);
this.destroy(e as Error);
}
}
}

0 comments on commit 02887ae

Please sign in to comment.