New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dep)!: upgrade gts 2.0.0 #194
Changes from 7 commits
f96802b
60d86bc
629025f
bbf6eea
751fd33
1b005a1
d849e34
fc3a18d
c4b3b37
26a1738
ebe5ae6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
**/node_modules | ||
src/**/doc/* | ||
**/.coverage | ||
build/ | ||
docs/ | ||
protos/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"extends": "./node_modules/gts" | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
node_modules/* | ||
samples/node_modules/* | ||
src/**/doc/* | ||
**/node_modules | ||
**/.coverage | ||
build/ | ||
docs/ | ||
protos/ |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright 2020 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
module.exports = { | ||
...require('gts/.prettierrc.json') | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,16 +7,16 @@ | |
"repository": "googleapis/nodejs-paginator", | ||
"scripts": { | ||
"test": "c8 mocha build/test", | ||
"lint": "gts check", | ||
"clean": "gts clean", | ||
"compile": "tsc -p .", | ||
"fix": "gts fix", | ||
"prelint": "cd samples; npm link ../; npm i", | ||
"lint": "gts check", | ||
"prepare": "npm run compile", | ||
"pretest": "npm run compile", | ||
"posttest": "npm run lint", | ||
"docs": "compodoc src/", | ||
"presystem-test": "npm run compile", | ||
"samples-test": "cd samples/ && npm link ../ && npm test && cd ../", | ||
"samples-test": "cd samples/ && npm link ../ && npm install && npm test && cd ../", | ||
"system-test": "mocha build/system-test", | ||
"docs-test": "linkinator docs", | ||
"predocs-test": "npm run docs" | ||
|
@@ -36,11 +36,15 @@ | |
"@types/proxyquire": "^1.3.28", | ||
"@types/sinon": "^7.0.0", | ||
"@types/uuid": "^7.0.0", | ||
"c8": "^7.0.0", | ||
"codecov": "^3.0.4", | ||
"gts": "^1.0.0", | ||
"eslint": "^6.8.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can drop all of these |
||
"eslint-config-prettier": "^6.0.0", | ||
"eslint-plugin-node": "^11.0.0", | ||
"eslint-plugin-prettier": "^3.1.0", | ||
"gts": "2.0.0-alpha.4", | ||
"linkinator": "^2.0.0", | ||
"mocha": "^7.0.0", | ||
"c8": "^7.0.0", | ||
"mocha": "^7.1.1", | ||
"proxyquire": "^2.0.1", | ||
"sinon": "^9.0.0", | ||
"typescript": "^3.8.3", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,7 +47,7 @@ export class ResourceStream<T> extends Transform implements ResourceEvents<T> { | |
this._requestsMade = 0; | ||
this._resultsToSend = args.maxResults === -1 ? Infinity : args.maxResults!; | ||
} | ||
// tslint:disable-next-line:no-any | ||
/* eslint-disable @typescript-eslint/no-explicit-any */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is fine for now, I would rather that these PRs turn into as minimal of a refactor as possible, even though we might want to come back and make this a more extensive refactor. |
||
end(...args: any[]) { | ||
this._ended = true; | ||
return super.end(...args); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcoe do we do this in other places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all that should be required is this:
which is what we use in other libraries,
npm link ../
should perform the install.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: The couple libraries I converted use
samples-test": "cd samples/ && npm link ../ && npm install && npm test && cd ../
, like https://github.com/googleapis/nodejs-monitoring/blob/master/package.json#L32