build!: update to latest version of gts/typescript #183
+60
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Mar 23, 2020
| @@ -1,3 +1,5 @@ | |||
| /* eslint-disable prefer-rest-params */ | |||
There was a problem hiding this comment.
We should move this after the license header I think
There was a problem hiding this comment.
removed the eslint-disable inline statements, we will probably want a replacement soonish depending on how migrating other libraries goes.
| @@ -66,8 +68,7 @@ export function promisify( | |||
| const slice = Array.prototype.slice; | |||
|
|
|||
| // tslint:disable-next-line:no-any | |||
There was a problem hiding this comment.
Sadly these won't work with eslint. There's a different syntax (which I can't remember right now) for disabling a line.
AVaksman
approved these changes
Mar 23, 2020
BREAKING CHANGE: typescript@3.7 introduced some breaking changes
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 220 219 -1
Branches 37 36 -1
=========================================
- Hits 220 219 -1
Continue to review full report at Codecov.
|
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 23, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/nodejs-promisify/compare/v1.0.4...v2.0.0) (2020-03-23) ### ⚠ BREAKING CHANGES * update to latest version of gts/typescript (#183) * drop Node 8 from engines field (#184) ### Features * drop Node 8 from engines field ([#184](https://www.github.com/googleapis/nodejs-promisify/issues/184)) ([7e6d3c5](https://www.github.com/googleapis/nodejs-promisify/commit/7e6d3c54066d89530ed25c7f9722efd252f43fb8)) ### Build System * update to latest version of gts/typescript ([#183](https://www.github.com/googleapis/nodejs-promisify/issues/183)) ([9c3ed12](https://www.github.com/googleapis/nodejs-promisify/commit/9c3ed12c12f4bb1e17af7440c6371c4cefddcd59)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
9f530f8 commit 9f530f8 Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Date: Mon Mar 23 18:58:21 2020 +0000 chore: release 2.0.0 (#185) 🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/nodejs-promisify/compare/v1.0.4...v2.0.0) (2020-03-23) ### ⚠ BREAKING CHANGES * update to latest version of gts/typescript (#183) * drop Node 8 from engines field (#184) ### Features * drop Node 8 from engines field ([#184](https://www.github.com/googleapis/nodejs-promisify/issues/184)) ([7e6d3c5](https://www.github.com/googleapis/nodejs-promisify/commit/7e6d3c54066d89530ed25c7f9722efd252f43fb8)) ### Build System * update to latest version of gts/typescript ([#183](https://www.github.com/googleapis/nodejs-promisify/issues/183)) ([9c3ed12](https://www.github.com/googleapis/nodejs-promisify/commit/9c3ed12c12f4bb1e17af7440c6371c4cefddcd59)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: typescript@3.7 introduced some breaking changes