Skip to content

Commit

Permalink
build!: update library to use Node 12 (#1564)
Browse files Browse the repository at this point in the history
* build!: Update library to use Node 12

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
sofisl and gcf-owl-bot[bot] committed May 20, 2022
1 parent b173d4c commit adb4319
Show file tree
Hide file tree
Showing 19 changed files with 197 additions and 323 deletions.
2 changes: 1 addition & 1 deletion .github/sync-repo-settings.yaml
Expand Up @@ -9,9 +9,9 @@ branchProtectionRules:
- "ci/kokoro: System test"
- docs
- lint
- test (10)
- test (12)
- test (14)
- test (16)
- cla/google
- windows
- OwlBot Post Processor
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10, 12, 14]
node: [12, 14, 16]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
34 changes: 0 additions & 34 deletions .kokoro/continuous/node10/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node10/docs.cfg

This file was deleted.

9 changes: 0 additions & 9 deletions .kokoro/continuous/node10/test.cfg

This file was deleted.

24 changes: 0 additions & 24 deletions .kokoro/continuous/node8/common.cfg

This file was deleted.

Empty file removed .kokoro/continuous/node8/test.cfg
Empty file.
34 changes: 0 additions & 34 deletions .kokoro/presubmit/node10/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/presubmit/node10/docs.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/presubmit/node10/lint.cfg

This file was deleted.

Empty file removed .kokoro/presubmit/node10/test.cfg
Empty file.
24 changes: 0 additions & 24 deletions .kokoro/presubmit/node8/common.cfg

This file was deleted.

Empty file removed .kokoro/presubmit/node8/test.cfg
Empty file.
12 changes: 6 additions & 6 deletions package.json
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc.",
"engines": {
"node": ">=10"
"node": ">=12.0.0"
},
"repository": "googleapis/nodejs-pubsub",
"main": "./build/src/index.js",
Expand Down Expand Up @@ -57,8 +57,8 @@
"@types/long": "^4.0.0",
"arrify": "^2.0.0",
"extend": "^3.0.2",
"google-auth-library": "^7.0.0",
"google-gax": "2.30.4",
"google-auth-library": "^8.0.2",
"google-gax": "^3.0.1",
"is-stream-ended": "^0.1.4",
"lodash.snakecase": "^4.1.1",
"p-defer": "^3.0.0"
Expand All @@ -80,12 +80,12 @@
"c8": "^7.0.0",
"codecov": "^3.0.0",
"execa": "^5.0.0",
"gts": "^2.0.0",
"gts": "^3.1.0",
"jsdoc": "^3.6.2",
"jsdoc-fresh": "^1.0.1",
"jsdoc-region-tag": "^1.0.2",
"linkinator": "^2.0.0",
"mocha": "^8.0.0",
"mocha": "^9.2.2",
"mv": "^2.1.1",
"ncp": "^2.0.0",
"null-loader": "^4.0.0",
Expand All @@ -94,7 +94,7 @@
"sinon": "^14.0.0",
"tmp": "^0.2.0",
"ts-loader": "^9.0.0",
"typescript": "^3.8.3",
"typescript": "^4.6.4",
"uuid": "^8.0.0",
"webpack": "^5.0.0",
"webpack-cli": "^4.0.0",
Expand Down
2 changes: 1 addition & 1 deletion samples/package.json
Expand Up @@ -9,7 +9,7 @@
"author": "Google Inc.",
"repository": "googleapis/nodejs-pubsub",
"engines": {
"node": ">=10"
"node": ">=12.0.0"
},
"scripts": {
"test": "mocha build/system-test --timeout 600000",
Expand Down
6 changes: 3 additions & 3 deletions src/message-queues.ts
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import {CallOptions, grpc} from 'google-gax';
import {CallOptions, grpc, ServiceError} from 'google-gax';
import defer = require('p-defer');

import {Message, Subscriber} from './subscriber';
Expand Down Expand Up @@ -214,7 +214,7 @@ export class AckQueue extends MessageQueue {
try {
await client.acknowledge(reqOpts, this._options.callOptions!);
} catch (e) {
throw new BatchError(e, ackIds, 'acknowledge');
throw new BatchError(e as ServiceError, ackIds, 'acknowledge');
}
}
}
Expand Down Expand Up @@ -258,7 +258,7 @@ export class ModAckQueue extends MessageQueue {
try {
await client.modifyAckDeadline(reqOpts, this._options.callOptions!);
} catch (e) {
throw new BatchError(e, ackIds, 'modifyAckDeadline');
throw new BatchError(e as ServiceError, ackIds, 'modifyAckDeadline');
}
});

Expand Down

0 comments on commit adb4319

Please sign in to comment.