Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use require() to load JSON protos #1285

Closed

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented May 10, 2021

The library is regenerated with gapic-generator-typescript v1.3.1.

Committer: @alexander-fenster
PiperOrigin-RevId: 372468161

Source-Link: googleapis/googleapis@75880c3

Source-Link: https://github.com/googleapis/googleapis-gen/commit/77b18044813d4c8c415ff9ea68e76e307eb8e904

The library is regenerated with gapic-generator-typescript v1.3.1.

Committer: @alexander-fenster
PiperOrigin-RevId: 372468161

Source-Link: googleapis/googleapis@75880c3

Source-Link: googleapis/googleapis-gen@77b1804
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners May 10, 2021 18:08
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label May 10, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1285 (6e1805a) into master (09c428a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
- Coverage   97.84%   97.84%   -0.01%     
==========================================
  Files          26       26              
  Lines       12700    12741      +41     
  Branches      558      605      +47     
==========================================
+ Hits        12426    12466      +40     
- Misses        268      269       +1     
  Partials        6        6              
Impacted Files Coverage Δ
src/publisher/index.ts 97.64% <100.00%> (+0.24%) ⬆️
src/publisher/message-batch.ts 100.00% <100.00%> (ø)
src/publisher/message-queues.ts 98.81% <100.00%> (+0.10%) ⬆️
src/topic.ts 98.66% <100.00%> (+0.02%) ⬆️
src/v1/publisher_client.ts 97.71% <100.00%> (-0.03%) ⬇️
src/v1/schema_service_client.ts 97.56% <100.00%> (-0.03%) ⬇️
src/v1/subscriber_client.ts 98.19% <100.00%> (-0.02%) ⬇️
src/pubsub.ts 99.46% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dee854...6e1805a. Read the comment docs.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@alexander-fenster
Copy link
Contributor

Taken care of by #1283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement. owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants