Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): correctly import long #541

Merged
merged 2 commits into from
Mar 11, 2019
Merged

fix(typescript): correctly import long #541

merged 2 commits into from
Mar 11, 2019

Conversation

callmehiphop
Copy link
Contributor

Fixes #526

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #541 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          16       16           
  Lines         965      965           
  Branches       86       86           
=======================================
  Hits          915      915           
  Misses         42       42           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffdda85...bdae275. Read the comment docs.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably use mkdirp for the directory creation, so that we work on Windows (and other platforms without mkdir).

Otherwise, this looks good to me; up to you whether you add mkdirp in another pull request (I probably would).

package.json Outdated Show resolved Hide resolved
@callmehiphop callmehiphop requested a review from bcoe March 11, 2019 20:32
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thank you \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants