feat(default_retention_period): Changes to backup.copy API to support the default retention period feature #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyaprakashg
commented
Jul 4, 2023
satyaprakashg
commented
…rt the default retention period feature With the default retention period feature, null value for expiration time is a valid value. If the expiration time is not specified (null) at the time of create backup then the backup will be retained for the duration of maximum retention period. In this commit, expireTime is made optional in CreateBackupOptions and backup.create API is fixed to handle the null value in the CreateBackupOptions.
… the default retention period feature With the default retention period feature, null value for expiration time is a valid value. If the expiration time is not specified (null) at the time of copy backup then the source backup expiration time will be used for expiring the destination backup as well. In this commit: expireTime is already optional in CopyBackupOptions and no changes are required to handle the case of missing expireTime in CopyBackupOptions. Adding unit-tests for copy backup for the current scenario and a few other scenarios (since they seem to be missing).
product-auto-label
bot
added
size: m
|
@surbhigarg92 Could you please review this diff. Also, please add "do not merge" tag on this diff since the backend changes are not merged yet. |
surbhigarg92
added
the
do not merge
surbhigarg92
reviewed
Jul 5, 2023
… the default retention period feature With the default retention period feature, null value for expiration time is a valid value. If the expiration time is not specified (null) at the time of copy backup then the source backup expiration time will be used for expiring the destination backup as well. In this commit: expireTime is already optional in CopyBackupOptions and no changes are required to handle the case of missing expireTime in CopyBackupOptions. Adding unit-tests for copy backup for the current scenario and a few other scenarios (since they seem to be missing).
surbhigarg92
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.