Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support for audience in client_options in v1 branch #411

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

parthea
Copy link
Collaborator

@parthea parthea commented Jul 13, 2022

feat: add api_key to client options in v1 branch

Cherry-pick #248 and #379 into v1 branch

These features are needed so that we can continue to support google-api-core 1.x in cloud client libraries.

Towards b/238481913

arithmetic1728 and others added 2 commits July 13, 2022 13:25
* feat: add api_key to client options

* update
feat: adds support for audience in client_options.
@parthea parthea requested review from a team as code owners July 13, 2022 13:30
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 13, 2022
@parthea
Copy link
Collaborator Author

parthea commented Jul 13, 2022

Unit tests pass locally for python 3.7 and 3.9

partheniou@partheniou-vm-2:~/git/python-api-core$ nox -s unit-3.9
nox > Running session unit-3.9
nox > Creating virtual environment (virtualenv) using python3.9 in .nox/unit-3-9
nox > python -m pip install mock pytest pytest-cov 'grpcio >= 1.0.2'
nox > python -m pip install -e . -c /usr/local/google/home/partheniou/git/python-api-core/testing/constraints-3.9.txt
nox > python -m pip install asyncmock pytest-asyncio proto-plus
nox > python -m py.test --quiet --cov=google.api_core --cov=tests.unit --cov-append --cov-config=.coveragerc --cov-report= --cov-fail-under=0 tests/unit --cov=tests.asyncio tests/asyncio
........................................................................ [ 14%]
........................................................................ [ 28%]
...................s.................................................... [ 43%]
........................................................................ [ 57%]
........................................................................ [ 72%]
........................................................................ [ 86%]
...................................................................      [100%]

 partheniou@partheniou-vm-2:~/git/python-api-core$ nox -s unit-3.7
nox > Running session unit-3.7
nox > Creating virtual environment (virtualenv) using python3.7 in .nox/unit-3-7
nox > python -m pip install mock pytest pytest-cov 'grpcio >= 1.0.2'
nox > python -m pip install -e . -c /usr/local/google/home/partheniou/git/python-api-core/testing/constraints-3.7.txt
nox > python -m pip install asyncmock pytest-asyncio proto-plus
nox > python -m py.test --quiet --cov=google.api_core --cov=tests.unit --cov-append --cov-config=.coveragerc --cov-report= --cov-fail-under=0 tests/unit --cov=tests.asyncio tests/asyncio
........................................................................ [ 14%]
........................................................................ [ 28%]
...................s.................................................... [ 43%]
........................................................................ [ 57%]
........................................................................ [ 72%]
........................................................................ [ 86%]
...................................................................      [100%]

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Jul 13, 2022
@parthea parthea merged commit 4834224 into v1 Jul 13, 2022
@parthea parthea deleted the add-audience-support branch July 13, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants