This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
chore: Adjust gapic namespace to google.cloud.bigquery_datatransfer #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using google.cloud.bigquery.datatransfer turned out to be too problematic to use with the google.cloud.bigquery library (namespace clashes).
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquerydatatransfer
plamut
commented
Sep 29, 2020
Comment on lines
+42
to
+53
| ### Version 2.1.0 | ||
|
|
||
| The library had its old namespace restored, since importing from | ||
| `google.cloud.bigquery` clashed with the `google-cloud-bigquery` library when the | ||
| latter was also installed. | ||
|
|
||
| The import paths that were changed in version `2.0.0` should be reverted: | ||
|
|
||
| ```py | ||
| from google.cloud import bigquery_datatransfer | ||
| from google.cloud import bigquery_datatransfer_v1 | ||
| ``` |
There was a problem hiding this comment.
This assumes we will release the namespace adjustment in v2.1.0.
Version 2.1.0 can be viewed as a non-trivial "fix" of the v2.0.0 release, but if we want to release it as v3.0.0, please comment below.
tswast
approved these changes
Sep 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on BigQuery storage PR. Using
google.cloud.bigquery.*namespace creates too many problems.