Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid unnecessary API call in QueryJob.result() when job is already finished #1900

Merged
merged 14 commits into from
Apr 18, 2024
Merged

fix: avoid unnecessary API call in QueryJob.result() when job is already finished #1900

merged 14 commits into from
Apr 18, 2024

Commits on Apr 12, 2024

  1. fix: avoid unnecessary API call in QueryJob.result() when job is alre… 

    …ady finished
    @tswast
    tswast committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    0c9a8a2 View commit details
    Browse the repository at this point in the history

  2. fix most unit tests

    @tswast
    tswast committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    07839b5 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. fix remaining unit tests

    @tswast
    tswast committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    5112315 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into tswast-fix-query-retry

    @tswast
    tswast committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    6297efd View commit details
    Browse the repository at this point in the history

  3. add timeout test, remove unneeded _done_or_raise override

    @tswast
    tswast committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    e5990eb View commit details
    Browse the repository at this point in the history

  4. treat even finished jobs as PENDING in query_and_wait since we want t… 

    …o trigger a job reload
    @tswast
    tswast committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    fddb557 View commit details
    Browse the repository at this point in the history

  5. remove unnecessary if statement

    @tswast
    tswast committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    6a43cfd View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. fix: retry query job after ambiguous failures

    @tswast
    tswast committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    12fa9fb View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
    @tswast @chalmerlowe
    tswast and chalmerlowe committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5149c25 View commit details
    Browse the repository at this point in the history

  2. add comments explaining expected sequences of API calls

    @tswast
    tswast committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4ee4975 View commit details
    Browse the repository at this point in the history

  3. explain timeout choice

    @tswast
    tswast committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    08373bc View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
    @tswast @chalmerlowe
    tswast and chalmerlowe committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2a587aa View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/tswast-fix-query-retry' into tsw… 

    …ast-fix-query-retry
    @tswast
    tswast committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f7f1e81 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Update google/cloud/bigquery/job/query.py

    @chalmerlowe
    chalmerlowe committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e42d8ad View commit details
    Browse the repository at this point in the history