Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support insertAll for range #1909

Merged
merged 6 commits into from May 6, 2024
Merged

feat: support insertAll for range #1909

merged 6 commits into from May 6, 2024

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented May 2, 2024 •
edited

  • _range_to_json() conversion function to use insertAll
  • unit tests for the conversion functions
  • supports client.insert_rows() with dictionary and tuple, in the form of a dictionary or string literal
  • adds client.insert_rows() unit tests for each case we do not test for inserting different data types here
  • client.insert_row_from_dataframe() just works

Fixes #<issue_number_goes_here> 馃

@Linchin Linchin requested review from a team as code owners May 2, 2024 22:09
@Linchin Linchin requested a review from leahecole May 2, 2024 22:09
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 2, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 2, 2024
@Linchin Linchin removed the request for review from leahecole May 2, 2024 22:12
@Linchin Linchin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 2, 2024
@Linchin Linchin assigned shollyman and unassigned mrfaizal May 2, 2024
alvarowolfx
alvarowolfx approved these changes May 3, 2024
View reviewed changes
google/cloud/bigquery/_helpers.py Outdated Show resolved Hide resolved
@Linchin Linchin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 3, 2024
@Linchin Linchin merged commit 74e75e8 into googleapis:main May 6, 2024
18 checks passed
@release-please release-please bot mentioned this pull request May 6, 2024
Merged
@Linchin Linchin mentioned this pull request May 10, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarowolfx alvarowolfx alvarowolfx approved these changes

@PhongChuong PhongChuong Awaiting requested review from PhongChuong

@shollyman shollyman Awaiting requested review from shollyman

Assignees

@shollyman shollyman

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Linchin @alvarowolfx @tswast @shollyman @mrfaizal