Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: incorporate will_accept() checks into publish() #108

Merged
merged 6 commits into from Jun 9, 2020
Merged

refactor: incorporate will_accept() checks into publish() #108

merged 6 commits into from Jun 9, 2020

Conversation

IlyaFaer
Copy link

Closes #105

@IlyaFaer IlyaFaer added api: pubsub Issues related to the googleapis/python-pubsub API. type: cleanup An internal cleanup or hygiene concern. labels May 28, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2020
@IlyaFaer IlyaFaer requested a review from pradn May 28, 2020 10:56
@IlyaFaer IlyaFaer marked this pull request as ready for review May 28, 2020 10:56
pradn
pradn requested changes May 28, 2020
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! I think we need to retain/add some tests. Otherwise, looks good.

tests/unit/pubsub_v1/publisher/batch/test_base.py Show resolved Hide resolved
tests/unit/pubsub_v1/publisher/batch/test_thread.py Show resolved Hide resolved
pradn
pradn approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

@pradn pradn added the automerge Merge the pull request once unit tests and other checks pass. label Jun 9, 2020
@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@meredithslota meredithslota requested a review from plamut June 9, 2020 20:53
@pradn pradn merged commit 6c7677e into googleapis:master Jun 9, 2020
@pradn
Copy link
Contributor

pradn commented Jun 9, 2020

Thanks @IlyaFaer !

@pradn pradn mentioned this pull request Jun 9, 2020
Closed
@release-please release-please bot mentioned this pull request Jun 9, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 9, 2020
@release-please
chore: release 1.6.0 (#117)
60fe71a 
## [1.6.0](https://www.github.com/googleapis/python-pubsub/compare/v1.5.0...v1.6.0) (2020-06-09)

### Features

* Add flow control for message publishing ([#96](https://www.github.com/googleapis/python-pubsub/issues/96)) ([06085c4](https://www.github.com/googleapis/python-pubsub/commit/06085c4083b9dccdd50383257799904510bbf3a0))


### Bug Fixes

* Fix PubSub incompatibility with api-core 1.17.0+ ([#103](https://www.github.com/googleapis/python-pubsub/issues/103)) ([c02060f](https://www.github.com/googleapis/python-pubsub/commit/c02060fbbe6e2ca4664bee08d2de10665d41dc0b))


### Documentation
- Clarify that Schedulers shouldn't be used with multiple SubscriberClients ([#100](#100)) ([cf9e87c](cf9e87c))
- Fix update subscription/snapshot/topic samples ([#113](#113)) ([e62c38b](e62c38b))


### Internal / Testing Changes
- Re-generated service implementaton using synth: removed experimental notes from the RetryPolicy and filtering features in anticipation of GA, added DetachSubscription (experimental) ([#114](#114)) ([0132a46](0132a46))
- Incorporate will_accept() checks into publish() ([#108](#108)) ([6c7677e](6c7677e))
@IlyaFaer IlyaFaer deleted the erase_will_accept_method branch June 10, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

@plamut plamut Awaiting requested review from plamut

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unused message arg in Batch.will_accept()
4 participants
@IlyaFaer @pradn @plamut @googlebot