Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: re-generated to pick up changes in the API or client library generator #114

Merged
merged 19 commits into from Jun 9, 2020
Merged

chore: re-generated to pick up changes in the API or client library generator #114

merged 19 commits into from Jun 9, 2020

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/99f854b3-bcbd-4ca9-a44c-2a6dea51ca52/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 314795690
Source-Link: googleapis/googleapis@86285bb
PiperOrigin-RevId: 313812131
Source-Link: googleapis/googleapis@fb21971
PiperOrigin-RevId: 313795529
Source-Link: googleapis/googleapis@f4bd71c
Source-Link: googleapis/synthtool@4e1d2cb
Source-Link: googleapis/synthtool@e99975b
Source-Link: googleapis/synthtool@ffe1040
Source-Link: googleapis/synthtool@71b8a27
PiperOrigin-RevId: 313488995
Source-Link: googleapis/googleapis@eafa840
PiperOrigin-RevId: 313460921
Source-Link: googleapis/googleapis@c4e3701
PiperOrigin-RevId: 313276022
Source-Link: googleapis/googleapis@f5f268f
PiperOrigin-RevId: 312689208
Source-Link: googleapis/googleapis@dec3204
Source-Link: googleapis/synthtool@d2364eb
Source-Link: googleapis/synthtool@7482e79
PiperOrigin-RevId: 310595049
Source-Link: googleapis/googleapis@73d4b5d
Source-Link: googleapis/synthtool@09c4846
PiperOrigin-RevId: 309824146
Source-Link: googleapis/googleapis@e0f9d9e

@yoshi-automation
Integrate Python GAPIC Microgenerator in googleapis. This PR uses usi…
48363bb 
…ng documentai as an example. Depends on googleapis/gapic-generator-python#402

PiperOrigin-RevId: 309824146

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 4 15:06:44 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb
Source-Link: googleapis/googleapis@e0f9d9e
@yoshi-automation
chore(python): create thread_safety doc
7db74ee 
This will be included in index.rst files. See https://github.com/googleapis/python-bigtable/pull/26/files

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue May 5 10:06:52 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 09c48461232ce929c34386259eb59018ad2d8eef
Source-Link: googleapis/synthtool@09c4846
@yoshi-automation
Removing the experimental tag from dead letter policy related fields.
04079c3 
PiperOrigin-RevId: 310595049

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri May 8 11:29:18 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 73d4b5d9a791f8b1ee63d439ffe909bb8ffa07f7
Source-Link: googleapis/googleapis@73d4b5d
@yoshi-automation
chore(python): remove extra #!/bin/bash
ba9ebf0 
Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue May 12 09:51:12 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 7482e79a82e353248769d819788adc1213e8c207
Source-Link: googleapis/synthtool@7482e79
@yoshi-automation
chore(python): remove one remaining extra bash line
e033f13 
To avoid generating bogus PRs

Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Author: Carlos de la Guardia <cguardia@yahoo.com>
Source-Date: Tue May 19 11:57:19 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e
Source-Link: googleapis/synthtool@d2364eb
@yoshi-automation
Upgrade protoc-docs-plugin version to 0.7.0 to fix unstable docstrings.
67c9e96 
PiperOrigin-RevId: 312689208

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu May 21 10:00:47 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: dec3204175104cef49bf21d685d5517caaf0058f
Source-Link: googleapis/googleapis@dec3204
@yoshi-automation
Add DetachSubscription RPC
ed0f227 
PiperOrigin-RevId: 313276022

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue May 26 15:11:32 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: f5f268f5293e60143ac742a4eeb7dd6306ebf505
Source-Link: googleapis/googleapis@f5f268f
@yoshi-automation
bazel: update protobuf, rules_go, gazelle, and gapic-generator-go ver…
0ba1013 
…sions - protobuf v3.12.1 - rules_go v0.23.0 - gazelle v0.21.0 - gapic-generator-go v0.14.1

PiperOrigin-RevId: 313460921

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed May 27 14:10:16 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: c4e37010d74071851ff24121f522e802231ac86e
Source-Link: googleapis/googleapis@c4e3701
@yoshi-automation
Use correct resource type for DetachSubscriptionRequest
c8b53e2 
PiperOrigin-RevId: 313488995

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed May 27 16:45:32 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: eafa840ceec23b44a5c21670288107c661252711
Source-Link: googleapis/googleapis@eafa840
@yoshi-automation
docs: update python docs template
ce7065d 
* docs: update python docs template

* sphinx change

Source-Author: kolea2 <45548808+kolea2@users.noreply.github.com>
Source-Date: Wed May 27 20:44:34 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 71b8a272549c06b5768d00fa48d3ae990e871bec
Source-Link: googleapis/synthtool@71b8a27
@yoshi-automation
feat: add templates for python samples projects
1d67056 
These templates will be used for templates in python-docs-samples
and in Python client libraries. The README generation code is a modified
version of
https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/scripts/readme-gen.

Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu May 28 14:39:58 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: ffe10407ee2f261c799fb0d01bf32a8abc67ed1e
Source-Link: googleapis/synthtool@ffe1040
@yoshi-automation
chore: update default ignores for Python libraries
a7aeb4b 
Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu May 28 14:43:37 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: e99975b6b49827b8720f0a885e218dbdb67849ca
Source-Link: googleapis/synthtool@e99975b
@yoshi-automation
feat: allow custom python versions in noxfile
1d360b5 
Libraries on the microgenerator support a smaller range of Python versions (3.6+).

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu May 28 18:22:04 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 4e1d2cb79b02d7496b1452f91c518630c207145e
Source-Link: googleapis/synthtool@4e1d2cb
@yoshi-automation
docs: Add comment for MessageStoragePolicy message
baebcb5 
PiperOrigin-RevId: 313795529

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri May 29 09:33:18 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: f4bd71cc173d848ec24d28eede271cca9abc411f
Source-Link: googleapis/googleapis@f4bd71c
@yoshi-automation
Drop the experimental tag on the Subscription filter and retry policy…
3f9341b 
… fields Clarify some retry policy comments

PiperOrigin-RevId: 313812131

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri May 29 10:59:34 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: fb21971becb6c0441efc855dabc371825732872c
Source-Link: googleapis/googleapis@fb21971
@yoshi-automation
Add "detached" bool to Subscription
4683a77 
PiperOrigin-RevId: 314795690

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Jun 4 13:43:59 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 86285bbd54fbf9708838219e3422aa47fb8fc0b0
Source-Link: googleapis/googleapis@86285bb
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2020
@pradn pradn changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. chore: re-generated to pick up changes in the API or client library generator Jun 5, 2020
plamut
plamut reviewed Jun 6, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for dealing with the recent docstring format issues!

I have two comments, but overall the changes look good to me.

noxfile.py
Comment on lines +29 to +31
DEFAULT_PYTHON_VERSION = "3.7"
SYSTEM_TEST_PYTHON_VERSIONS = ["2.7", "3.7"]
UNIT_TEST_PYTHON_VERSIONS = ["2.7", "3.5", "3.6", "3.7", "3.8"]
Copy link
Contributor

@plamut plamut Jun 6, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be overridden on the next autogen pass, shouldn't we add the rules to synth.py to fill in the blanks, and spare ourselves future work? Proposing because this is what actually gets generated:

DEFAULT_PYTHON_VERSION = ""
SYSTEM_TEST_PYTHON_VERSIONS = []
UNIT_TEST_PYTHON_VERSIONS = []

scripts/readme-gen/templates/install_portaudio.tmpl.rst
Comment on lines +1 to +2
Install PortAudio
+++++++++++++++++
Copy link
Contributor

@plamut plamut Jun 6, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this template needed in this repo?

I assume the template just sits there and does nothing, is committing such templates a common workflow?

(the same for any other templates that might not be necessary)

@plamut plamut requested a review from pradn June 6, 2020 07:55
@plamut
Copy link
Contributor

plamut commented Jun 9, 2020

As discussed offline with @pradn - there is value in getting this in and make a new release. The review comments can be addressed separately, they are not blockers.

plamut
plamut approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Jun 9, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0132a46 into master Jun 9, 2020
@release-please release-please bot mentioned this pull request Jun 9, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 9, 2020
@release-please
chore: release 1.6.0 (#117)
60fe71a 
## [1.6.0](https://www.github.com/googleapis/python-pubsub/compare/v1.5.0...v1.6.0) (2020-06-09)

### Features

* Add flow control for message publishing ([#96](https://www.github.com/googleapis/python-pubsub/issues/96)) ([06085c4](https://www.github.com/googleapis/python-pubsub/commit/06085c4083b9dccdd50383257799904510bbf3a0))


### Bug Fixes

* Fix PubSub incompatibility with api-core 1.17.0+ ([#103](https://www.github.com/googleapis/python-pubsub/issues/103)) ([c02060f](https://www.github.com/googleapis/python-pubsub/commit/c02060fbbe6e2ca4664bee08d2de10665d41dc0b))


### Documentation
- Clarify that Schedulers shouldn't be used with multiple SubscriberClients ([#100](#100)) ([cf9e87c](cf9e87c))
- Fix update subscription/snapshot/topic samples ([#113](#113)) ([e62c38b](e62c38b))


### Internal / Testing Changes
- Re-generated service implementaton using synth: removed experimental notes from the RetryPolicy and filtering features in anticipation of GA, added DetachSubscription (experimental) ([#114](#114)) ([0132a46](0132a46))
- Incorporate will_accept() checks into publish() ([#108](#108)) ([6c7677e](6c7677e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. context: full
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yoshi-automation @plamut @pradn @googlebot @busunkim96