Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor client classes for safer type checking #552

Merged
merged 11 commits into from Jan 19, 2022
Merged

fix: refactor client classes for safer type checking #552

merged 11 commits into from Jan 19, 2022

Commits on Jan 18, 2022

  1. Directly subclass generated PublisherClient

    @plamut
    plamut committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    3c67b13 View commit details
    Browse the repository at this point in the history

  2. Directly subclass generated SubscriberClient

    @plamut
    plamut committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    1daefde View commit details
    Browse the repository at this point in the history

  3. Remove unneded GAPIC helper

    @plamut
    plamut committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    1eefc6d View commit details
    Browse the repository at this point in the history

  4. Remove pytype 

    There are no real advantages over mypy, but at the same time several
downsides such as being slow, producing more false positives, etc.
    @plamut
    plamut committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    5fe9c35 View commit details
    Browse the repository at this point in the history

  5. Re-enable mypy_samples nox session

    @plamut
    plamut committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    048d109 View commit details
    Browse the repository at this point in the history

  6. Convert a comment to docstring in publisher client

    @plamut
    plamut committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    ace0a03 View commit details
    Browse the repository at this point in the history

  7. Add api property back, but deprecated

    @plamut
    plamut committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    4457779 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Merge branch 'main' into iss-536-refactor-composition

    @plamut
    plamut committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    1e7bd04 View commit details
    Browse the repository at this point in the history

  2. Assure that mypy_samples is not commented out

    @plamut
    plamut committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    8e6b76b View commit details
    Browse the repository at this point in the history

  3. Remove redundant type hint casts

    @plamut
    plamut committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    67a12c4 View commit details
    Browse the repository at this point in the history

  4. Disable mypy_samples session until blockers resolved

    @plamut
    plamut committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    7c210c7 View commit details
    Browse the repository at this point in the history