Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: create subscription with filtering enabled #580

Merged
merged 2 commits into from Feb 9, 2022
Merged

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Feb 8, 2022

Towards b/214396829.

The test output string looks something like 'Created subscription with filtering enabled: name: "projects/tz-playground-bigdata/subscriptions/subscription-test-su...: 604800\n}\nexpiration_policy {\n ttl {\n seconds: 2678400\n }\n}\nfilter: "attributes.author=\\"unknown\\""\n\n', which is the reason for assert '"attributes.author=\\"unknown\\""' in out in the test.

@anguillanneuf anguillanneuf requested review from a team as code owners February 8, 2022 21:32
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Feb 8, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 8, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 8, 2022
@anguillanneuf anguillanneuf merged commit ce87155 into main Feb 9, 2022
@anguillanneuf anguillanneuf deleted the filtering branch February 9, 2022 00:16
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pradn pradn mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants