Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use stdlib warnings module instead of a third party dependency #1120

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

asottile-sentry
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

see also #1037 (comment)

@asottile-sentry asottile-sentry requested review from a team as code owners March 27, 2024 15:10
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 27, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Mar 27, 2024
Copy link
Contributor

@ankiaga ankiaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

@ankiaga ankiaga enabled auto-merge (squash) March 28, 2024 03:35
@parthea parthea changed the title use stdlib warnings module instead of a third party dependency fix: use stdlib warnings module instead of a third party dependency Apr 12, 2024
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2024
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2024
@ankiaga ankiaga merged commit 37ac4c1 into googleapis:main Apr 12, 2024
11 of 13 checks passed
@asottile-sentry asottile-sentry deleted the stdlib-warnings branch April 12, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants