Skip to content

Commit

Permalink
fix: bump python-auth version to fix issue and remove workaround (#1158)
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewsg committed Oct 11, 2023
1 parent aefcdd4 commit 28c02dd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
1 change: 0 additions & 1 deletion google/cloud/storage/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ def __init__(
# are passed along, for use in __reduce__ defined elsewhere.
self._initial_client_info = client_info
self._initial_client_options = client_options
self._initial_credentials = credentials

kw_args = {"client_info": client_info}

Expand Down
7 changes: 5 additions & 2 deletions google/cloud/storage/transfer_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -1154,11 +1154,14 @@ def _call_method_on_maybe_pickled_blob(


def _reduce_client(cl):
"""Replicate a Client by constructing a new one with the same params."""
"""Replicate a Client by constructing a new one with the same params.
LazyClient performs transparent caching for when the same client is needed
on the same process multiple times."""

client_object_id = id(cl)
project = cl.project
credentials = cl._initial_credentials
credentials = cl._credentials
_http = None # Can't carry this over
client_info = cl._initial_client_info
client_options = cl._initial_client_options
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
# 'Development Status :: 5 - Production/Stable'
release_status = "Development Status :: 5 - Production/Stable"
dependencies = [
"google-auth >= 1.25.0, < 3.0dev",
"google-auth >= 2.23.3, < 3.0dev",
"google-api-core >= 1.31.5, <3.0.0dev,!=2.0.*,!=2.1.*,!=2.2.*,!=2.3.0",
"google-cloud-core >= 2.3.0, < 3.0dev",
"google-resumable-media >= 2.6.0",
Expand Down

0 comments on commit 28c02dd

Please sign in to comment.