Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip tests if the required packages are not installed #170

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jan 25, 2024

As per the snippet below, tests in test_lower_bound_checker.py require that specific packages in tests/unit/resources be installed in the same environment. If those packages don't exist during test time, we should mark the test as skipped.

# These packages are installed into the environment by the nox session
# See 'resources/' for the setup.py files
GOOD_PACKAGE = "valid-package"
BAD_PACKAGE = "invalid-package"

Fixes #168 🦕

@parthea parthea requested a review from a team as a code owner January 25, 2024 21:11
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 25, 2024
@parthea parthea mentioned this pull request Jan 25, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 26, 2024
@parthea parthea force-pushed the skip-tests-if-required-package-is-not-installed branch from ae67dee to ebba1c8 Compare January 26, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 tests fail
2 participants