fix: throw underlying API error when the manifest fetch commits when determining the latest released version #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
chingor13
changed the title
chingor13
changed the title
bcoe
reviewed
Aug 11, 2022
If set, we will throw the underlying API error if we have received too many 502 errors.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
🤖 I have created a release *beep* *boop* --- ## [13.21.0](v13.20.0...v13.21.0) (2022-08-11) ### Features * parse versioning type from the manifest config ([#1572](#1572)) ([8a7bfc1](8a7bfc1)), closes [#1569](#1569) ### Bug Fixes * throw underlying API error when the manifest fetch commits when determining the latest released version ([#1571](#1571)) ([0944bde](0944bde)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, GitHub's GraphQL endpoint throws 502s when it takes too long to execute a query. We usually silently retry these requests (with exponential backoff). Previously, if too many attempts are made, we return an empty response. We introduce a new
requireResponseoption which will tell our GraphQL executor to throw the underlying API error if a response is required.Fixes #1567