feat(api): add commit fields to access authors and PR number #1717
Conversation
| associatedPRs.forEach(pr => { | ||
| pr.commits.nodes.forEach(node => { | ||
| node.commit.authors.nodes | ||
| .map(author => author.name) | ||
| .forEach(authors.add, authors); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I think this will grab authors that are not necessarily intended. Associated pull requests include any PRs that are mentioned in the commit message, not necessarily the PR that created it.
So if we mention another PR by another author, this will grab that PR's author who should not necessarily be attached to the current PR.
This weird behavior is why we have that logic to find the associated pull request whose merge commit SHA matches the commit SHA (skip the mentioned PRs)
There was a problem hiding this comment.
I'm a little puzzled, and I'm a little curious about what scenario this will happen in. Can you tell me how to trigger this problem?
There was a problem hiding this comment.
If you reference another PR in the PR body like See #1234, then graphql will return that as an associatedPullRequest.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1716