fix: when includeComponentInTag is false, there should be no component in the branch name #2212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating why release-please did not open a PR here: googleapis/gax-nodejs#1553
The CLI fails with the warning:
(here):
release-please/src/strategies/base.ts
Line 615 in 72b0ab3
That is true, since the branch does not contain the component:
It kind of makes sense that the branchName wouldn't contain the component, since we're setting that in the config (https://github.com/googleapis/gax-nodejs/blob/c65cee0fd56ff2682d5cfb91ca639ee98e93f568/release-please-config.json#L11)
We can mirror what
getComponent
has, here:release-please/src/strategies/base.ts
Line 163 in 72b0ab3
getBranchComponent