Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when includeComponentInTag is false, there should be no component in the branch name #2212

Closed
wants to merge 2 commits into from

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Feb 1, 2024

I was investigating why release-please did not open a PR here: googleapis/gax-nodejs#1553

The CLI fails with the warning:

⚠ PR component: undefined does not match configured component: google-gax

(here):

`PR component: ${branchName.component} does not match configured component: ${branchComponent}`

That is true, since the branch does not contain the component:
Screenshot 2024-02-01 at 1 44 57 AM

It kind of makes sense that the branchName wouldn't contain the component, since we're setting that in the config (https://github.com/googleapis/gax-nodejs/blob/c65cee0fd56ff2682d5cfb91ca639ee98e93f568/release-please-config.json#L11)

We can mirror what getComponent has, here:

if (!this.includeComponentInTag) {
in getBranchComponent

@sofisl sofisl requested review from a team as code owners February 1, 2024 09:46
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 1, 2024
@sofisl sofisl closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants