Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use package name to build aggregate if present #2219

Closed
wants to merge 2 commits into from

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Feb 9, 2024

We've been having an ongoing bug, where release-please does not create a branch with the component name for the release (example: googleapis/gax-nodejs#1560)

This is weird, because the release-itself has the correct branch name up to this line:

newReleasePullRequests.push({

But this correct name gets lost after the Merge plugin is run:

return newReleasePullRequests.map(

The least disruptive solution I found is to mirror how the (correct) branch name gets selected in base.ts:

const branchName = branchComponent

Base looks for a component or packageName to determine the type of branch. I think the merge strategy should do the same.

See a longer explanation of this bug (which I don't think this totally resolves, but at least preserves some functionality: #2214

@sofisl sofisl requested review from a team as code owners February 9, 2024 00:20
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 9, 2024
@sofisl sofisl closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants