fix: use package name to build aggregate if present #2219
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been having an ongoing bug, where release-please does not create a branch with the component name for the release (example: googleapis/gax-nodejs#1560)
This is weird, because the release-itself has the correct branch name up to this line:
release-please/src/manifest.ts
Line 749 in 72b0ab3
But this correct name gets lost after the
Merge
plugin is run:release-please/src/manifest.ts
Line 795 in 72b0ab3
The least disruptive solution I found is to mirror how the (correct) branch name gets selected in
base.ts
:release-please/src/strategies/base.ts
Line 302 in 72b0ab3
Base looks for a component or packageName to determine the type of branch. I think the merge strategy should do the same.
See a longer explanation of this bug (which I don't think this totally resolves, but at least preserves some functionality: #2214