Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add troubleshooting guide for the scenario that release PR is merged with autorelease:closed #2255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Open

docs: Add troubleshooting guide for the scenario that release PR is merged with autorelease:closed #2255

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e6824e
doc: Update troubleshooting.md
blakeli0 Mar 29, 2024
59d98f2
Update troubleshooting.md
blakeli0 Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/troubleshooting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,6 @@ more API calls (which is one reason a manifest config is preferred).
3. Iterate through the latest tags and compare against commit
SHAs seen in the last 250 commits on the branch. This is to
ensure that the tag happened on this target branch.

### What if my release PR is merged with `autorelease:closed`?
Copy link
Member

@suztomo suztomo Mar 29, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This heading is the cause of a problem "Why does my merged release pull request not trigger the release job?"

The release PR will be tagged with `autorelease:closed` on closing of the PR, but it will not be tagged with `autorelease:pending` on re-opening of the PR. Hence if a release PR was accidentally closed and re-opened before merging to main, release-please wouldn't be triggred. In such case, please manually remove `autorelease:closed`, add `autorelease: pending` and `release-please:force-run` to the release PR to force re-trigger the release process. See https://github.com/googleapis/google-cloud-java/pull/10615 for example.