Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for GitHub releases and Ruby #137

Merged
merged 4 commits into from Nov 1, 2019
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Oct 31, 2019

This adds support to our bot for creating GitHub releases, if handleGHRelease is set to true.

This is exciting to me because it allows me to start adding release-please to non-autorelease repos, e.g., yargs.


This also updates the version of release-please used by by the bot, which has additional functionality added for @TheRoyalTnetennba; Ruby will be using the Ruby release type for the bot, not RubyYoshi.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2019
@bcoe bcoe changed the title feat: support for GitHub releases feat: support for GitHub releases and Ruby Oct 31, 2019
import {
GitHubRelease,
GitHubReleaseOptions,
} from 'release-please/build/src/github-release';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably export these types from the index, so consumers are resilient to files moving around.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call.

@bcoe bcoe merged commit 8c10eb7 into master Nov 1, 2019
@bcoe bcoe deleted the handle-gh-release branch November 1, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants