feat: Add extra_opts for C# proto generation #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to set the base_namespace (or other options) on the rare occasions when that's necessary.
1 task
noahdietz
approved these changes
May 10, 2023
There was a problem hiding this comment.
This is a start, but I think you will want to also update the Bazel file generator to retain the extra_opts argument if specified in an existing Bazel file (i.e. its being regenerated). Otherwise, it will get blown away on regen. You can do it in this PR or another, I don't mind. If you want help lmk. A recent example of something similar (but for PHP) would be #155.
|
I'd prefer to do it in another PR if possible, so we can get this through to unblock googleapis/google-cloud-dotnet#10322 Happy to do the follow-up early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to set the base_namespace (or other options) on the rare occasions when that's necessary.