feat(bazel): stop generating php_grpc_library #159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops generation of the
php_grpc_library
. The output of this target is not used in google-cloud-php. google-ads-php ships the generated output, but those BUILD.bazel files are built from a different tool.Once this lands in googleapis, we will likely want to remove all
php_grpc_library
targets in packages we manage.cc: @bshaffer