feat(bazel): Retain extra_opts in C# rule #161
Conversation
jskeet
added
the
do not merge
jskeet
force-pushed
the
csharp_opts_tooling
branch
6 times, most recently
from
bb0db16
to
cb6fd36
Compare
| @@ -346,6 +346,7 @@ load( | |||
|
|
|||
| csharp_proto_library( | |||
| name = "library_csharp_proto", | |||
| extra_opts = ["base_namespace=Google.Cloud.AIPlatform.V1"], | |||
There was a problem hiding this comment.
We will need to add this attribute to the template file(s). Something like the following:
extra_opts = [{{csharp_extra_opts}}],
Like what was done here
Then you will also need to add the code to populate the "template data" with the attribute "csharp_extra_opts", like what was done here
All of this means that we will have to generate an empty extra_opts attribute if it was not set at all :/
There was a problem hiding this comment.
All of this means that we will have to generate an empty extra_opts attribute if it was not set at all :/
Urgh. Ah well... I don't think it'll do any harm. Thanks for the nudge - will have a look now...
There was a problem hiding this comment.
Okay, I think this is now ready. It required a certain amount of guesswork, as the order of attributes in the mustache-not-mustache file wasn't honored in some cases, but the tests now pass...
jskeet
force-pushed
the
csharp_opts_tooling
branch
10 times, most recently
from
6afab30
to
21ca9c8
Compare
jskeet
removed
the
do not merge
jskeet
force-pushed
the
csharp_opts_tooling
branch
from
21ca9c8
to
5a370be
Compare
No description provided.