feat(bazel): retain importpath in Go rules #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahdietz
reviewed
May 15, 2023
| @@ -135,6 +135,8 @@ public void testRegeneration() throws IOException, InterruptedException { | |||
| gapicBuildFilePath, "library_java_gapic", "transport", "rest"); | |||
| buildozer.batchRemoveAttribute( | |||
| gapicBuildFilePath, "library_py_gapic", "rest_numeric_enums"); | |||
| buildozer.batchSetStringAttribute( | |||
| gapicBuildFilePath, "library_go_gapic", "importpath", "cloud.google.com/go/example/library/apiv1;library"); | |||
There was a problem hiding this comment.
If this is being changed to differ from the "pure generated" baseline file, I think the updated.baseline file should contain that change as well. Basically, this should be something different than what is generated normally.
noahdietz
approved these changes
May 15, 2023
noahdietz
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.