fix: add handwritten_layer option to indicate whether libraries have a veneer #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
changed the title
| @@ -70,6 +70,7 @@ class ApiVersionedDir { | |||
| // Multiple languages: | |||
| "package_name", | |||
| "transport", | |||
| "handwritten_layer", | |||
There was a problem hiding this comment.
It only belongs to TypeScript so should be one line below :)
There was a problem hiding this comment.
Hm, currently only TS uses it but it could be used by any language. Do you still want to move it?
alexander-fenster
approved these changes
May 25, 2023
There was a problem hiding this comment.
LGTM (but please move it down one line).
After this is done, please make a release (this repo is on release-please so the release PR should appear automatically as usual) and update the version of rules_gapic in three WORKSPACE files internally. Ping me if you need more guidance with that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.