Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bazel): type-only csharp assembly pkg #171

Merged
merged 5 commits into from
Aug 7, 2023
Merged

fix(bazel): type-only csharp assembly pkg #171

merged 5 commits into from
Aug 7, 2023

Conversation

noahdietz
Copy link
Contributor

Adds assmebly_pkg target generation for type-only packages (those that do not have any proto service definitions within), and stops including the csharp_grpc_library target since there is no gRPC code to generate without a service.

Part of b/281092541.

@noahdietz noahdietz requested a review from jskeet August 4, 2023 19:56
@noahdietz noahdietz requested review from a team as code owners August 4, 2023 19:56
@jskeet
Copy link
Collaborator

jskeet commented Aug 4, 2023

Will look on Monday.

jskeet
jskeet approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@noahdietz noahdietz merged commit b9fa7da into googleapis:main Aug 7, 2023
4 checks passed
@noahdietz noahdietz deleted the csharp-types branch August 7, 2023 18:20
@release-please release-please bot mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noahdietz @jskeet @alexander-fenster